netdev - Re: [PATCH net-next] net: call skb_defer_free_flush() from __napi_busy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zd8USSc6Yxea5ft9@nanopsycho>
Date: Wed, 28 Feb 2024 12:08:57 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, eric.dumazet@...il.com,
	Samiullah Khawaja <skhawaja@...gle.com>,
	Stanislav Fomichev <sdf@...gle.com>
Subject: Re: [PATCH net-next] net: call skb_defer_free_flush() from
 __napi_busy_loop()

Tue, Feb 27, 2024 at 10:01:04PM CET, edumazet@...gle.com wrote:
>skb_defer_free_flush() is currently called from net_rx_action()
>and napi_threaded_poll().
>
>We should also call it from __napi_busy_loop() otherwise
>there is the risk the percpu queue can grow until an IPI
>is forced from skb_attempt_defer_free() adding a latency spike.
>
>Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>Cc: Samiullah Khawaja <skhawaja@...gle.com>
>Cc: Stanislav Fomichev <sdf@...gle.com>

Reviewed-by: Jiri Pirko <jiri@...dia.com>