netdev - Re: [PATCH net-next v2 2/4] nfp: update devlink device info output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zd8kBY-pUjKWBGFv@nanopsycho>
Date: Wed, 28 Feb 2024 13:16:05 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Louis Peens <louis.peens@...igine.com>
Cc: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Fei Qin <fei.qin@...igine.com>,
	netdev@...r.kernel.org, oss-drivers@...igine.com
Subject: Re: [PATCH net-next v2 2/4] nfp: update devlink device info output

Wed, Feb 28, 2024 at 08:51:38AM CET, louis.peens@...igine.com wrote:
>From: Fei Qin <fei.qin@...igine.com>
>
>Newer NIC will introduce a new part number, now add it
>into devlink device info.
>
>Signed-off-by: Fei Qin <fei.qin@...igine.com>
>Signed-off-by: Louis Peens <louis.peens@...igine.com>
>---
> Documentation/networking/devlink/nfp.rst         | 3 +++
> drivers/net/ethernet/netronome/nfp/nfp_devlink.c | 3 ++-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/Documentation/networking/devlink/nfp.rst b/Documentation/networking/devlink/nfp.rst
>index a1717db0dfcc..f79d46472012 100644
>--- a/Documentation/networking/devlink/nfp.rst
>+++ b/Documentation/networking/devlink/nfp.rst
>@@ -42,6 +42,9 @@ The ``nfp`` driver reports the following versions
>    * - ``board.model``
>      - fixed
>      - Model name of the board design
>+   * - ``part_number``
>+     - fixed
>+     - Part number of the entire product
>    * - ``fw.bundle_id``
>      - stored, running
>      - Firmware bundle id
>diff --git a/drivers/net/ethernet/netronome/nfp/nfp_devlink.c b/drivers/net/ethernet/netronome/nfp/nfp_devlink.c
>index 635d33c0d6d3..5b41338d55c4 100644
>--- a/drivers/net/ethernet/netronome/nfp/nfp_devlink.c
>+++ b/drivers/net/ethernet/netronome/nfp/nfp_devlink.c
>@@ -159,7 +159,8 @@ static const struct nfp_devlink_versions_simple {
> 	{ DEVLINK_INFO_VERSION_GENERIC_BOARD_ID,	"assembly.partno", },
> 	{ DEVLINK_INFO_VERSION_GENERIC_BOARD_REV,	"assembly.revision", },
> 	{ DEVLINK_INFO_VERSION_GENERIC_BOARD_MANUFACTURE, "assembly.vendor", },
>-	{ "board.model", /* code name */		"assembly.model", },
>+	{ DEVLINK_INFO_VERSION_GENERIC_BOARD_MODEL,	"assembly.model", },
>+	{ DEVLINK_INFO_VERSION_GENERIC_PART_NUMBER,     "pn", },

Could this be 2 patches? One logical change per patch please.


> };
> 
> static int
>-- 
>2.34.1
>
>