netdev - Re: [PATCH] net: ethernet: ti: am65-cpsw-qos: fix non-bql configs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <debdd4e5-d3f2-4199-a2f7-825e37b212da@app.fastmail.com>
Date: Wed, 28 Feb 2024 15:54:19 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Dave Taht" <dave.taht@...il.com>, "Arnd Bergmann" <arnd@...nel.org>
Cc: "David S . Miller" <davem@...emloft.net>,
 "Eric Dumazet" <edumazet@...gle.com>, "Jakub Kicinski" <kuba@...nel.org>,
 "Paolo Abeni" <pabeni@...hat.com>, "Breno Leitao" <leitao@...ian.org>,
 "Roger Quadros" <rogerq@...nel.org>,
 "Siddharth Vadapalli" <s-vadapalli@...com>,
 "Grygorii Strashko" <grygorii.strashko@...com>,
 "Dan Carpenter" <dan.carpenter@...aro.org>, Netdev <netdev@...r.kernel.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: ti: am65-cpsw-qos: fix non-bql configs

On Wed, Feb 28, 2024, at 15:44, Dave Taht wrote:
> but why do you want to disable BQL?

I have no idea, I'm just doing randconfig build tests.

I assume Breno has an answer for that, at least he
sent the patch that triggered the regression, see below.

     Arnd

commit ea7f3cfaa58873bbe271577efa800647e30f18bd
Author: Breno Leitao <leitao@...ian.org>
Date:   Thu Feb 15 09:05:07 2024 -0800

    net: bql: allow the config to be disabled

    It is impossible to disable BQL individually today, since there is no
    prompt for the Kconfig entry, so, the BQL is always enabled if SYSFS is
    enabled.

    Create a prompt entry for BQL, so, it could be enabled or disabled at
    build time independently of SYSFS.

    Signed-off-by: Breno Leitao <leitao@...ian.org>
    Signed-off-by: David S. Miller <davem@...emloft.net>

diff --git a/net/Kconfig b/net/Kconfig
index 4adc47d0c9c2..3e57ccf0da27 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -331,6 +331,7 @@ config NET_RX_BUSY_POLL

 config BQL
        bool
+       prompt "Enable Byte Queue Limits"
        depends on SYSFS
        select DQL
        default y