netdev - Re: [PATCH v2 net-next 03/15] ipv6: addrconf_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iLEC=Eb8nHtk8f4YOY6zzoaDrbzorBu0yF5dS2-5KeHiA@mail.gmail.com>
Date: Wed, 28 Feb 2024 16:14:20 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S . Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, 
	David Ahern <dsahern@...nel.org>, Jiri Pirko <jiri@...dia.com>, netdev@...r.kernel.org, 
	eric.dumazet@...il.com
Subject: Re: [PATCH v2 net-next 03/15] ipv6: addrconf_disable_ipv6() optimizations

On Wed, Feb 28, 2024 at 4:11 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 28 Feb 2024 10:28:28 +0100 Eric Dumazet wrote:
> > > Good catch, I simply misread the line.
> >
> > I note that addrconf_disable_policy() does not have a similar write.
> >
> > When writing on net->ipv6.devconf_all->disable_policy, we loop over all idev
> > to call addrconf_disable_policy_idev(),
> > but we do _not_ change net->ipv6.devconf_dflt->disable_policy
> >
> > This seems quite strange we change net->ipv6.devconf_dflt->disable_ipv6 when
> > user only wanted to change net->ipv6.devconf_all->disable_policy
>
> The all / default behavior is a complete mess, I don't mind changing!
> I commented because there was a flake in TCP-AO tests and I was trying
> to find any functional changes :)

Sure, this is a change that needs more investigation if anyone has interest ;)