netdev - Re: [PATCH net-next 7/7] net: nexthop: Expose nexthop group HW stats to user space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h6hso6fa.fsf@nvidia.com>
Date: Wed, 28 Feb 2024 18:16:22 +0100
From: Petr Machata <petrm@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Petr Machata <petrm@...dia.com>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	<netdev@...r.kernel.org>, Ido Schimmel <idosch@...dia.com>, David Ahern
	<dsahern@...nel.org>, <mlxsw@...dia.com>, "Gustavo A . R . Silva"
	<gustavoars@...nel.org>, Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH net-next 7/7] net: nexthop: Expose nexthop group HW
 stats to user space


Jakub Kicinski <kuba@...nel.org> writes:

> On Tue, 27 Feb 2024 19:17:32 +0100 Petr Machata wrote:
>> +	if (nla_put_u32(skb, NHA_HW_STATS_ENABLE, nhg->hw_stats))
>> +		goto nla_put_failure;
>> +
>> +	if (op_flags & NHA_OP_FLAG_DUMP_HW_STATS &&
>> +	    nhg->hw_stats) {
>> +		err = nh_grp_hw_stats_update(nh, &hw_stats_used);
>> +		if (err)
>> +			goto hw_stats_update_fail;
>> +
>> +		if (nla_put_u32(skb, NHA_HW_STATS_USED, hw_stats_used))
>> +			goto nla_put_failure;
>
> Something's off with the jump targets here.
> clang detects nest is not initialized and you'll try to cancel it

Yes, the nest only starts below. Will fix.
>
>> +	}
>> +
>>  	nest = nla_nest_start(skb, NHA_GROUP_STATS);
>>  	if (!nest)
>>  		return -EMSGSIZE;