netdev - Re: [Intel-wired-lan] [PATCH net] i40e: Fix firmware version comparison function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0c35b34-a845-4221-b9d3-867d2f339f8d@molgen.mpg.de>
Date: Wed, 28 Feb 2024 18:33:58 +0100
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Ivan Vecera <ivecera@...hat.com>
Cc: netdev@...r.kernel.org, intel-wired-lan@...ts.osuosl.org,
 Jesse Brandeburg <jesse.brandeburg@...el.com>,
 open list <linux-kernel@...r.kernel.org>, Eric Dumazet
 <edumazet@...gle.com>, Tony Nguyen <anthony.l.nguyen@...el.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 "David S. Miller" <davem@...emloft.net>
Subject: Re: [Intel-wired-lan] [PATCH net] i40e: Fix firmware version
 comparison function

Dear Ivan,


Thank you for your patch.

Am 28.02.24 um 18:26 schrieb Ivan Vecera:
> Helper i40e_is_fw_ver_eq() compares incorrectly given firmware version
> as it returns true when the major version of running firmware is
> greater than the given major version that is wrong and results in

… version. That …

> failure during getting of DCB configuration where this helper is used.
> Fix the check and return true only if the running FW version is exactly
> equals to the given version.

is … equal

> Reproducer:
> 1. Load i40e driver
> 2. Check dmesg output
> 
> [root@...t ~]# modprobe i40e
> [root@...t ~]# dmesg | grep 'i40e.*DCB'
> [   74.750642] i40e 0000:02:00.0: Query for DCB configuration failed, err -EIO aq_err I40E_AQ_RC_EINVAL
> [   74.759770] i40e 0000:02:00.0: DCB init failed -5, disabled
> [   74.966550] i40e 0000:02:00.1: Query for DCB configuration failed, err -EIO aq_err I40E_AQ_RC_EINVAL
> [   74.975683] i40e 0000:02:00.1: DCB init failed -5, disabled
> 
> Fixes: cf488e13221f ("i40e: Add other helpers to check version of running firmware and AQ API")
> Signed-off-by: Ivan Vecera <ivecera@...hat.com>
> ---
>   drivers/net/ethernet/intel/i40e/i40e_prototype.h | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_prototype.h b/drivers/net/ethernet/intel/i40e/i40e_prototype.h
> index af4269330581..ce1f11b8ad65 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_prototype.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e_prototype.h
> @@ -567,8 +567,7 @@ static inline bool i40e_is_fw_ver_lt(struct i40e_hw *hw, u16 maj, u16 min)
>    **/
>   static inline bool i40e_is_fw_ver_eq(struct i40e_hw *hw, u16 maj, u16 min)
>   {
> -	return (hw->aq.fw_maj_ver > maj ||
> -		(hw->aq.fw_maj_ver == maj && hw->aq.fw_min_ver == min));
> +	return (hw->aq.fw_maj_ver == maj && hw->aq.fw_min_ver == min);
>   }
>   
>   #endif /* _I40E_PROTOTYPE_H_ */

With the nits in the commit message addressed, this is

Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>


Kind regards,

Paul