netdev - RE: [PATCH net] igb: extend PTP timestamp adjustments to i211

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR11MB5095A06D5B78F7544E88E614D6582@PH0PR11MB5095.namprd11.prod.outlook.com>
Date: Wed, 28 Feb 2024 17:43:03 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>, Jiri Pirko <jiri@...nulli.us>
CC: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "davem@...emloft.net"
	<davem@...emloft.net>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"richardcochran@...il.com" <richardcochran@...il.com>,
	"nathan.sullivan@...com" <nathan.sullivan@...com>, "Pucha, HimasekharX Reddy"
	<himasekharx.reddy.pucha@...el.com>
Subject: RE: [PATCH net] igb: extend PTP timestamp adjustments to i211



> -----Original Message-----
> From: Oleksij Rempel <o.rempel@...gutronix.de>
> Sent: Wednesday, February 28, 2024 4:28 AM
> To: Jiri Pirko <jiri@...nulli.us>
> Cc: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; davem@...emloft.net;
> kuba@...nel.org; pabeni@...hat.com; edumazet@...gle.com;
> netdev@...r.kernel.org; richardcochran@...il.com; nathan.sullivan@...com;
> Keller, Jacob E <jacob.e.keller@...el.com>; Pucha, HimasekharX Reddy
> <himasekharx.reddy.pucha@...el.com>
> Subject: Re: [PATCH net] igb: extend PTP timestamp adjustments to i211
> 
> On Wed, Feb 28, 2024 at 10:37:56AM +0100, Jiri Pirko wrote:
> > Tue, Feb 27, 2024 at 07:49:41PM CET, anthony.l.nguyen@...el.com wrote:
> > >From: Oleksij Rempel <o.rempel@...gutronix.de>
> > >
> > >The i211 requires the same PTP timestamp adjustments as the i210,
> > >according to its datasheet. To ensure consistent timestamping across
> > >different platforms, this change extends the existing adjustments to
> > >include the i211.
> > >
> > >The adjustment result are tested and comparable for i210 and i211 based
> > >systems.
> > >
> > >Fixes: 3f544d2a4d5c ("igb: adjust PTP timestamps for Tx/Rx latency")
> >
> > IIUC, you are just extending the timestamp adjusting to another HW, not
> > actually fixing any error, don't you? In that case, I don't see why not
> > to rather target net-next and avoid "Fixes" tag. Or do I misunderstand
> > this?
> 
> From my perspective, it was an error, since two nearly identical systems
> with only one difference (one used i210 other i211) showed different PTP
> measurements. So, it would be nice if distributions would include this
> fix. On other hand, I'm ok with what ever maintainer would decide how
> to handle this patch.
> 
> Regards,
> Oleksij

Without this, the i211 doesn't apply the Tx/Rx latency adjustments, so the timestamps would be less accurate than if the corrections are applied. On the one hand I guess this is a "feature" and the lack of a feature isn't a bug, so maybe its not viewed as a bug fix then.

Another interpretation is that lacking those corrections is a bug which this patch fixes.

Thanks,
Jake

> --
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |