netdev - Re: [PATCH net-next 4/7] net: nexthop: Expose nexthop group stats to user space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240227193555.39e56436@kernel.org>
Date: Tue, 27 Feb 2024 19:35:55 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Petr Machata <petrm@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 <netdev@...r.kernel.org>, Ido Schimmel <idosch@...dia.com>, "David Ahern"
 <dsahern@...nel.org>, <mlxsw@...dia.com>
Subject: Re: [PATCH net-next 4/7] net: nexthop: Expose nexthop group stats
 to user space

On Tue, 27 Feb 2024 19:17:29 +0100 Petr Machata wrote:
> +	NHA_GROUP_STATS_ENTRY_PAD = NHA_GROUP_STATS_ENTRY_UNSPEC,
> +
> +	/* u32; nexthop id of the nexthop group entry */
> +	NHA_GROUP_STATS_ENTRY_ID,
> +
> +	/* u64; number of packets forwarded via the nexthop group entry */
> +	NHA_GROUP_STATS_ENTRY_PACKETS,

auto-int, please - nla_put_uint() etc.
No need for the padding or guessing how big the value needs to be.