netdev - Re: [PATCH net-next] tcp: remove some holes in struct tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 28 Feb 2024 08:56:25 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, Naman Gulati <namangulati@...gle.com>,
	eric.dumazet@...il.com
Subject: Re: [PATCH net-next] tcp: remove some holes in struct tcp_sock

Tue, Feb 27, 2024 at 08:27:21PM CET, edumazet@...gle.com wrote:
>By moving some fields around, this patch shrinks
>holes size from 56 to 32, saving 24 bytes on 64bit arches.
>
>After the patch pahole gives the following for 'struct tcp_sock':
>
>	/* size: 2304, cachelines: 36, members: 162 */
>	/* sum members: 2234, holes: 6, sum holes: 32 */
>	/* sum bitfield members: 34 bits, bit holes: 5, sum bit holes: 14 bits */
>	/* padding: 32 */
>	/* paddings: 3, sum paddings: 10 */
>	/* forced alignments: 1, forced holes: 1, sum forced holes: 12 */
>
>Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Jiri Pirko <jiri@...dia.com>