netdev - [PATCH net v2] Net:cache didn't flush when ipv6 rule changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <696e39599c7a5e793a9d96aceef0e34817ab0bb2.camel@mediatek.com>
Date: Wed, 28 Feb 2024 08:24:55 +0000
From: Lena Wang (王娜) <Lena.Wang@...iatek.com>
To: "davem@...emloft.net" <davem@...emloft.net>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"dsahern@...nel.org" <dsahern@...nel.org>, "edumazet@...gle.com"
	<edumazet@...gle.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Shiming Cheng (成诗明) <Shiming.Cheng@...iatek.com>
Subject: [PATCH net v2] Net:cache didn't flush when ipv6 rule changed

From bf53859b379a653eec8a14fbb3f29286f9f888fb Mon Sep 17 00:00:00 2001
From: shiming cheng <shiming.cheng@...iatek.com>
Date: Mon, 26 Feb 2024 20:17:58 +0800
Subject: [PATCH net v2] Net:cache didn't flush when ipv6 rule changed

When changed from old rule&route configure to new one as below,
ipv6 cache dst_entry did not change to new route table as no
cache flush callback function, then forward to wrong out interface.
When fib6_check dst_entry, the fib6_node version[fn_sernm] is
always the same with socket dst_cookie, old cache dst_entry is
always used and no chance to update.

So we need to update fib6_node version when rule changed and
flush cache to avoid dispatching a wrong interface.

Signed-off-by: shiming cheng <shiming.cheng@...iatek.com>
---
v2: 
    1. Add the fix tag.
    2. Changes according to David Ahern's suggestions, modify flush
functions same way as ipv4 flush cache and use tabs to aligh with
existing code.
---
---
 net/ipv6/fib6_rules.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/net/ipv6/fib6_rules.c b/net/ipv6/fib6_rules.c
index 7523c4baef35..52c04f0ac498 100644
--- a/net/ipv6/fib6_rules.c
+++ b/net/ipv6/fib6_rules.c
@@ -449,6 +449,11 @@ static size_t fib6_rule_nlmsg_payload(struct
fib_rule *rule)
 	       + nla_total_size(16); /* src */
 }
 
+static void fib6_rule_flush_cache(struct fib_rules_ops *ops)
+{
+	rt_genid_bump_ipv6(ops->fro_net);
+}
+
 static const struct fib_rules_ops __net_initconst
fib6_rules_ops_template = {
 	.family			= AF_INET6,
 	.rule_size		= sizeof(struct fib6_rule),
@@ -461,6 +466,7 @@ static const struct fib_rules_ops __net_initconst
fib6_rules_ops_template = {
 	.compare		= fib6_rule_compare,
 	.fill			= fib6_rule_fill,
 	.nlmsg_payload		= fib6_rule_nlmsg_payload,
+	.flush_cache		= fib6_rule_flush_cache,
 	.nlgroup		= RTNLGRP_IPV6_RULE,
 	.owner			= THIS_MODULE,
 	.fro_net		= &init_net,
-- 
2.18.0