netdev - Re: [PATCH net v3] ipv6:flush ipv6 route cache when rule is changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZeBCpOAiQ_-DKEKi@nanopsycho>
Date: Thu, 29 Feb 2024 09:39:00 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Lena Wang (王娜) <Lena.Wang@...iatek.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dsahern@...nel.org" <dsahern@...nel.org>,
	"kuba@...nel.org" <kuba@...nel.org>,
	Shiming Cheng (成诗明) <Shiming.Cheng@...iatek.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH net v3] ipv6:flush ipv6 route cache when rule is changed

Thu, Feb 29, 2024 at 09:24:54AM CET, Lena.Wang@...iatek.com wrote:
>On Wed, 2024-02-28 at 16:50 +0100, Jiri Pirko wrote:
>>  	 
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>  Wed, Feb 28, 2024 at 04:38:56PM CET, Lena.Wang@...iatek.com wrote:
>> >From: Shiming Cheng <shiming.cheng@...iatek.com>
>> >
>> >When rule policy is changed, ipv6 socket cache is not refreshed.
>> >The sock's skb still uses a outdated route cache and was sent to
>> >a wrong interface.
>> >
>> >To avoid this error we should update fib node's version when
>> >rule is changed. Then skb's route will be reroute checked as
>> >route cache version is already different with fib node version.
>> >The route cache is refreshed to match the latest rule.
>> >
>> >Signed-off-by: Shiming Cheng <shiming.cheng@...iatek.com>
>> >Signed-off-by: Lena Wang <lena.wang@...iatek.com>
>> 
>> 1) You are still missing Fixes tags, I don't know what to say.
>I am sorry for the confuse. My previous change log of fix tag is a
>wrong description for "PATCH net v2".
>
>Current patch doesn't fix previous commit. It is more like missing
>flush since the first commit 101367c2f8c4 of creating fib6_rules.c. Is
>it OK to add this fix or omit fix tag?

No, the "Fixes" tag needs to be present. In this case, it looks like:
Fixes: 101367c2f8c4 ("[IPV6]: Policy Routing Rules")
Is the appropriate one. Isn't it?

>
>> 2) Re patch subject:
>>    "ipv6:flush ipv6 route cache when rule is changed"
>>    Could it be:
>>    "ipv6: fib6_rules: flush route cache when rule is changed"
>>    ? please.
>Yes, I will update later in v4.
>
>> 3) Could you please honor the 24h hours resubmission rule:
>> 
>https://www.kernel.org/doc/html/v6.6/process/maintainer-netdev.html#tl-dr
>> 
>OK. I will follow the rule later.
>
>> pw-bot: cr