[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240229102557.615c02f3@wsk>
Date: Thu, 29 Feb 2024 10:25:57 +0100
From: Lukasz Majewski <lukma@...x.de>
To: Andrew Lunn <andrew@...n.ch>
Cc: Stephen Hemminger <stephen@...workplumber.org>, Oleksij Rempel
<o.rempel@...gutronix.de>, Eric Dumazet <edumazet@...gle.com>, Florian
Fainelli <f.fainelli@...il.com>, Vladimir Oltean <olteanv@...il.com>,
"David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
netdev@...r.kernel.org, Tristram.Ha@...rochip.com, Sebastian Andrzej
Siewior <bigeasy@...utronix.de>, Paolo Abeni <pabeni@...hat.com>, Ravi
Gunasekaran <r-gunasekaran@...com>, Simon Horman <horms@...nel.org>,
Wojciech Drewek <wojciech.drewek@...el.com>, Nikita Zhandarovich
<n.zhandarovich@...tech.ru>, Murali Karicheri <m-karicheri2@...com>, Dan
Carpenter <dan.carpenter@...aro.org>, Ziyang Xuan
<william.xuanziyang@...wei.com>, Kristian Overskeid <koverskeid@...il.com>,
Matthieu Baerts <matttbe@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [RFC] net: hsr: Provide RedBox support
Hi Andrew,
> On Wed, Feb 28, 2024 at 08:31:15AM -0800, Stephen Hemminger wrote:
> > On Wed, 28 Feb 2024 16:07:35 +0100
> > Lukasz Majewski <lukma@...x.de> wrote:
> >
> > >
> > > +/* hsr_proxy_node_table_show - Formats and prints proxy
> > > node_table entries */ +static int
> > > +hsr_proxy_node_table_show(struct seq_file *sfp, void *data)
> > > +{
> > > + struct hsr_priv *priv = (struct hsr_priv *)sfp->private;
> > > + struct hsr_node *node;
> > > +
> > > + seq_printf(sfp, "Proxy Node Table entries for HSR
> > > device\n");
> > > + seq_puts(sfp, "MAC-Address-SAN, time_in\n");
> > > + rcu_read_lock();
> > > + list_for_each_entry_rcu(node, &priv->proxy_node_db,
> > > mac_list) {
> > > + seq_printf(sfp, "%pM ", &node->macaddress_A[0]);
> > > + seq_printf(sfp, "%10lx\n",
> > > node->time_in[HSR_PT_INTERLINK]);
> > > + }
> > > + rcu_read_unlock();
> > > + return 0;
> > > +}
> > > +
> > > DEFINE_SHOW_ATTRIBUTE(hsr_node_table);
> > > +DEFINE_SHOW_ATTRIBUTE(hsr_proxy_node_table);
> >
> > NAK
> > Do not abuse sysfs to be a debug proc style output.
>
> This is actually debugfs, not sysfs.
>
> However, i agree, we want information like this exported via netlink
> as the primary interface to the end user. debugfs is not suitable for
> that.
Am I correct, that recommended approach would be to:
1. Modify iproute2 to support for example:
ip addr show dev hsr1 nodes {proxy} ?
2. Shall the currently exported:
/sys/kernel/debug/hsr/hsrX/node_table be left as it is (for legacy
usage) or shall it be removed and replaced with netlink and iproute2 ?
>
> Andrew
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@...x.de
Content of type "application/pgp-signature" skipped
Powered by blists - more mailing lists