[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240229104117.4edf96ae@kmaincent-XPS-13-7390>
Date: Thu, 29 Feb 2024 10:41:17 +0100
From: Köry Maincent <kory.maincent@...tlin.com>
To: Simon Horman <horms@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
<pabeni@...hat.com>, Jonathan Corbet <corbet@....net>, Luis Chamberlain
<mcgrof@...nel.org>, Russ Weight <russ.weight@...ux.dev>, Greg
Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki"
<rafael@...nel.org>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski
<krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
Oleksij Rempel <o.rempel@...gutronix.de>, Mark Brown <broonie@...nel.org>,
Frank Rowand <frowand.list@...il.com>, Andrew Lunn <andrew@...n.ch>, Heiner
Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
devicetree@...r.kernel.org, Dent Project <dentproject@...uxfoundation.org>
Subject: Re: [PATCH net-next v5 13/17] net: pse-pd: Use regulator framework
within PSE framework
On Wed, 28 Feb 2024 12:48:01 +0000
Simon Horman <horms@...nel.org> wrote:
> On Tue, Feb 27, 2024 at 03:42:55PM +0100, Kory Maincent wrote:
>
> ...
>
> > diff --git a/include/linux/pse-pd/pse.h b/include/linux/pse-pd/pse.h
> > index 522115cc6cef..a3e297cc2150 100644
> > --- a/include/linux/pse-pd/pse.h
> > +++ b/include/linux/pse-pd/pse.h
> > @@ -55,10 +55,10 @@ struct pse_controller_ops {
> > int (*ethtool_get_status)(struct pse_controller_dev *pcdev,
> > unsigned long id, struct netlink_ext_ack *extack,
> > struct pse_control_status *status);
> > - int (*ethtool_set_config)(struct pse_controller_dev *pcdev,
> > - unsigned long id, struct netlink_ext_ack *extack,
> > - const struct pse_control_config *config);
> > int (*setup_pi_matrix)(struct pse_controller_dev *pcdev);
> > + int (*pi_is_enabled)(struct pse_controller_dev *pcdev, int id);
> > + int (*pi_enable)(struct pse_controller_dev *pcdev, int id);
> > + int (*pi_disable)(struct pse_controller_dev *pcdev, int id);
>
> Hi Kory,
>
> Please update the Kernel doc for struct pse_controller_ops to reflect the
> added and removed fields.
Hello Simon,
Sorry I totally forgot to update the kernel doc on that patch.
Regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
Powered by blists - more mailing lists