netdev - Re: [PATCH net-next 0/6] inet: no longer use RTNL to protect inet_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 29 Feb 2024 15:18:39 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jiri Pirko <jiri@...dia.com>, David Ahern <dsahern@...nel.org>,
	netdev@...r.kernel.org, Florian Westphal <fw@...len.de>,
	eric.dumazet@...il.com
Subject: Re: [PATCH net-next 0/6] inet: no longer use RTNL to protect
 inet_dump_ifaddr()

Thu, Feb 29, 2024 at 12:40:10PM CET, edumazet@...gle.com wrote:
>This series convert inet so that a dump of addresses (ip -4 addr)
>no longer requires RTNL.
>
>Eric Dumazet (6):
>  inet: annotate data-races around ifa->ifa_tstamp and ifa->ifa_cstamp
>  inet: annotate data-races around ifa->ifa_valid_lft
>  inet: annotate data-races around ifa->ifa_preferred_lft
>  inet: annotate data-races around ifa->ifa_flags
>  inet: prepare inet_base_seq() to run without RTNL
>  inet: use xa_array iterator to implement inet_dump_ifaddr()
>
> net/core/dev.c     |   5 +-
> net/ipv4/devinet.c | 166 +++++++++++++++++++++------------------------
> 2 files changed, 79 insertions(+), 92 deletions(-)

Looks fine to me.

set-
Reviewed-by: Jiri Pirko <jiri@...dia.com>