netdev - Re: [PATCH net-next 1/2] net: adopt skb_network

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78861e3e-be81-a279-6a97-c9cef85f8205@gmail.com>
Date: Thu, 29 Feb 2024 15:52:38 +0000
From: Edward Cree <ecree.xilinx@...il.com>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, Florian Westphal <fw@...len.de>,
 eric.dumazet@...il.com
Subject: Re: [PATCH net-next 1/2] net: adopt skb_network_offset() and similar
 helpers

On 29/02/2024 09:39, Eric Dumazet wrote:
> This is a cleanup patch, making code a bit more concise.
> 
> 1) Use skb_network_offset(skb) in place of
>        (skb_network_header(skb) - skb->data)
> 
> 2) Use -skb_network_offset(skb) in place of
>        (skb->data - skb_network_header(skb))
> 
> 3) Use skb_transport_offset(skb) in place of
>        (skb_transport_header(skb) - skb->data)
> 
> 4) Use skb_inner_transport_offset(skb) in place of
>        (skb_inner_transport_header(skb) - skb->data)
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Acked-by: Edward Cree <ecree.xilinx@...il.com> # for sfc