netdev - Re: [PATCH net] igb: extend PTP timestamp adjustments to i211

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240229121452.2272d01c@kernel.org>
Date: Thu, 29 Feb 2024 12:14:52 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: "Keller, Jacob E" <jacob.e.keller@...el.com>
Cc: Oleksij Rempel <o.rempel@...gutronix.de>, Jiri Pirko <jiri@...nulli.us>,
 "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "davem@...emloft.net"
 <davem@...emloft.net>, "pabeni@...hat.com" <pabeni@...hat.com>,
 "edumazet@...gle.com" <edumazet@...gle.com>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, "richardcochran@...il.com"
 <richardcochran@...il.com>, "nathan.sullivan@...com"
 <nathan.sullivan@...com>, "Pucha, HimasekharX Reddy"
 <himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH net] igb: extend PTP timestamp adjustments to i211

On Thu, 29 Feb 2024 20:09:03 +0000 Keller, Jacob E wrote:
> > On Wed, 28 Feb 2024 17:43:03 +0000 Keller, Jacob E wrote:  
> > > Without this, the i211 doesn't apply the Tx/Rx latency adjustments,
> > > so the timestamps would be less accurate than if the corrections are
> > > applied. On the one hand I guess this is a "feature" and the lack of
> > > a feature isn't a bug, so maybe its not viewed as a bug fix then.  
> > 
> > I tossed a coin and it said.... "whatever, man". Such sass, tsk tsk.  
> 
> I might have not had enough caffiene when writing that email... 😊

Sorry, my bad, I was barely awake. What I meant to convey is that
it's borderline, so discussing how people feel is not a good use of
anyone's time.

It's a 3 LoC change to include one chip in what's done for another chip,
it has been well tested, and has user impact. It's fine.