netdev - Re: [PATCH net-next v2 2/4] nfp: update devlink device info output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240228203458.4a7234f5@kernel.org>
Date: Wed, 28 Feb 2024 20:34:58 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Louis Peens <louis.peens@...igine.com>
Cc: David Miller <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, Fei
 Qin <fei.qin@...igine.com>, netdev@...r.kernel.org,
 oss-drivers@...igine.com
Subject: Re: [PATCH net-next v2 2/4] nfp: update devlink device info output

On Wed, 28 Feb 2024 09:51:38 +0200 Louis Peens wrote:
> +   * - ``part_number``
> +     - fixed
> +     - Part number of the entire product

Belongs in the previous patch..

>     * - ``fw.bundle_id``
>       - stored, running
>       - Firmware bundle id
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_devlink.c b/drivers/net/ethernet/netronome/nfp/nfp_devlink.c
> index 635d33c0d6d3..5b41338d55c4 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_devlink.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_devlink.c
> @@ -159,7 +159,8 @@ static const struct nfp_devlink_versions_simple {
>  	{ DEVLINK_INFO_VERSION_GENERIC_BOARD_ID,	"assembly.partno", },
>  	{ DEVLINK_INFO_VERSION_GENERIC_BOARD_REV,	"assembly.revision", },
>  	{ DEVLINK_INFO_VERSION_GENERIC_BOARD_MANUFACTURE, "assembly.vendor", },
> -	{ "board.model", /* code name */		"assembly.model", },
> +	{ DEVLINK_INFO_VERSION_GENERIC_BOARD_MODEL,	"assembly.model", },

Ah, it is the code name. I don't understand why you're trying to make
this generic. I never seen other vendors report code names for boards.