netdev - RE: [PATCH net 1/3] net: lan743x: disable WOL upon resume to restore full data path operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <LV8PR11MB8700B74600C2FEC3687D2B379F5F2@LV8PR11MB8700.namprd11.prod.outlook.com>
Date: Thu, 29 Feb 2024 04:57:05 +0000
From: <Raju.Lakkaraju@...rochip.com>
To: <andrew@...n.ch>
CC: <netdev@...r.kernel.org>, <davem@...emloft.net>, <kuba@...nel.org>,
	<linux-kernel@...r.kernel.org>, <Bryan.Whitehead@...rochip.com>,
	<richardcochran@...il.com>, <UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH net 1/3] net: lan743x: disable WOL upon resume to restore
 full data path operation

Hi Andrew,

Thank you for review comments.

> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Tuesday, February 27, 2024 7:09 AM
> To: Raju Lakkaraju - I30499 <Raju.Lakkaraju@...rochip.com>
> Cc: netdev@...r.kernel.org; davem@...emloft.net; kuba@...nel.org; linux-
> kernel@...r.kernel.org; Bryan Whitehead - C21958
> <Bryan.Whitehead@...rochip.com>; richardcochran@...il.com;
> UNGLinuxDriver <UNGLinuxDriver@...rochip.com>
> Subject: Re: [PATCH net 1/3] net: lan743x: disable WOL upon resume to
> restore full data path operation
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> On Mon, Feb 26, 2024 at 01:39:32PM +0530, Raju Lakkaraju wrote:
> > In order for datapath to be restored to normal functionality after
> > resume we disable all wakeup events. Additionally we clear all W1C
> > status bits by writing 1's to them.
> 
> Just to make sure i'm understanding this correctly, you are just clearing that
> there was been a WoL wakeup. The WoL configuration is not cleared, so i
> could suspend the device again and wake it up with WoL. There is no need for
> me to use ethtool, the WoL configuration is preserved.

Yes. Your understanding is correct.
WoL configuration is not cleared. 
This clean-up helps us when resume from sleep due to system events.
There is no need to use ethtool's configure WOL again.

> 
>         Andrew

Thanks,
Raju