[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240301152621.GC403078@kernel.org>
Date: Fri, 1 Mar 2024 15:26:21 +0000
From: Simon Horman <horms@...nel.org>
To: Rand Deeb <rand.sec96@...il.com>
Cc: Jesse Brandeburg <jesse.brandeburg@...el.com>,
Tony Nguyen <anthony.l.nguyen@...el.com>,
"David S . Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>, intel-wired-lan@...ts.osuosl.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
deeb.rand@...fident.ru, lvc-project@...uxtesting.org,
voskresenski.stanislav@...fident.ru
Subject: Re: [PATCH] net: ice: Fix potential NULL pointer dereference in
ice_bridge_setlink()
On Wed, Feb 28, 2024 at 06:54:48PM +0300, Rand Deeb wrote:
> The function ice_bridge_setlink() may encounter a NULL pointer dereference
> if nlmsg_find_attr() returns NULL and br_spec is dereferenced subsequently
> in nla_for_each_nested(). To address this issue, add a check to ensure that
> br_spec is not NULL before proceeding with the nested attribute iteration.
>
> Signed-off-by: Rand Deeb <rand.sec96@...il.com>
Thanks Rand,
I do wonder if for some reason this cannot ever occur.
But assuming it can then I agree with the fix.
Reviewed-by: Simon Horman <horms@...nel.org>
As a fix I think it probably warrants a fixes tag and
being applied to net. As such, the following seems appropriate.
Fixes: b1edc14a3fbf ("ice: Implement ice_bridge_getlink and ice_bridge_setlink")
...
Powered by blists - more mailing lists