netdev - Re: [PATCH net-next] dpll: avoid multiple function calls to dump netdev info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZeH26t7WPkfwUnhs@nanopsycho>
Date: Fri, 1 Mar 2024 16:40:26 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, vadim.fedorenko@...ux.dev,
	arkadiusz.kubalewski@...el.com
Subject: Re: [PATCH net-next] dpll: avoid multiple function calls to dump
 netdev info

Fri, Mar 01, 2024 at 01:16:07AM CET, kuba@...nel.org wrote:
>Due to compiler oddness and because struct dpll_pin is defined
>in a private header we have to call into dpll code to get
>the handle for the pin associated with a netdev.
>Combine getting the pin pointer and getting the info into
>a single function call by having the helpers take a netdev
>pointer, rather than expecting a pin.
>
>The exports are note needed, networking core can't be a module.
>
>Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Jiri Pirko <jiri@...dia.com>


>---
>BTW is the empty nest if the netdev has no pin intentional?

The user can tell if this is or is not supported by kernel easily.

>Should we add a comment explaining why it's there?

Yeah.