netdev - Re: [PATCH net-next v2 6/7] net: nexthop: Add ability to enable / disable hardware statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e22ebccf-c65b-49d8-814f-a17e9186eb90@kernel.org>
Date: Fri, 1 Mar 2024 08:49:26 -0700
From: David Ahern <dsahern@...nel.org>
To: Petr Machata <petrm@...dia.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc: Ido Schimmel <idosch@...dia.com>, Simon Horman <horms@...nel.org>,
 mlxsw@...dia.com
Subject: Re: [PATCH net-next v2 6/7] net: nexthop: Add ability to enable /
 disable hardware statistics

On 2/29/24 11:16 AM, Petr Machata wrote:
> From: Ido Schimmel <idosch@...dia.com>
> 
> Add netlink support for enabling collection of HW statistics on nexthop
> groups.
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> Signed-off-by: Petr Machata <petrm@...dia.com>
> ---
>  include/net/nexthop.h        |  2 ++
>  include/uapi/linux/nexthop.h |  3 +++
>  net/ipv4/nexthop.c           | 15 ++++++++++++++-
>  3 files changed, 19 insertions(+), 1 deletion(-)
> 

> diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c
> index 02629ba7a75d..15f108c440ae 100644
> --- a/net/ipv4/nexthop.c
> +++ b/net/ipv4/nexthop.c
> @@ -37,6 +37,7 @@ static const struct nla_policy rtm_nh_policy_new[] = {
>  	[NHA_ENCAP]		= { .type = NLA_NESTED },
>  	[NHA_FDB]		= { .type = NLA_FLAG },
>  	[NHA_RES_GROUP]		= { .type = NLA_NESTED },
> +	[NHA_HW_STATS_ENABLE]	= NLA_POLICY_MAX(NLA_U32, 1),

numbers typically need a name or comment.

Reviewed-by: David Ahern <dsahern@...nel.org>