netdev - Re: [PATCH net-next v2 4/7] net: nexthop: Expose nexthop group stats to user space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87v865na5d.fsf@nvidia.com>
Date: Fri, 1 Mar 2024 18:17:28 +0100
From: Petr Machata <petrm@...dia.com>
To: David Ahern <dsahern@...nel.org>
CC: Petr Machata <petrm@...dia.com>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>, <netdev@...r.kernel.org>, Ido Schimmel
	<idosch@...dia.com>, Simon Horman <horms@...nel.org>, <mlxsw@...dia.com>
Subject: Re: [PATCH net-next v2 4/7] net: nexthop: Expose nexthop group
 stats to user space


David Ahern <dsahern@...nel.org> writes:

> On 2/29/24 11:16 AM, Petr Machata wrote:
>> +enum {
>> +	NHA_GROUP_STATS_ENTRY_UNSPEC,
>> +
>> +	/* u32; nexthop id of the nexthop group entry */
>> +	NHA_GROUP_STATS_ENTRY_ID,
>> +
>> +	/* uint; number of packets forwarded via the nexthop group entry */
>
> why not make it a u64?

uint will store it as 32-bit if possible and as 64-bit if necessary.