netdev - [PATCH Linux-6.8-rc5 1/1] ixgbevf: start negotiate with api version 1.4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240301235837.3741422-1-yifei.l.liu@oracle.com>
Date: Fri,  1 Mar 2024 15:58:37 -0800
From: Yifei Liu <yifei.l.liu@...cle.com>
To: jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com
Cc: yifei.l.liu@...cle.com, harshit.m.mogalapalli@...cle.com,
        intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, jack.vogel@...cle.com,
        lihong.yang@...el.com, ramanan.govindarajan@...cle.com
Subject: [PATCH Linux-6.8-rc5 1/1] ixgbevf: start negotiate with api version 1.4

ixgbevf updates to api version to 1.5 via
	commit 339f28964147d ("ixgbevf: Add support for new mailbox
	communication between PF and VF")
while the pf side is not updated to 1.5 properly. It will lead to a
failure of negotiation of api version 1.5 This commit will enforce
the negotiation to start with 1.4 which is working fine.

Normally the pf and vf side should be updated together. Example:
	commit adef9a26d6c39 ("ixgbevf: add defines for IPsec offload request")
	commit 7269824046376 ("ixgbe: add VF IPsec offload request message handling")


Reported-by: Manjunatha Gowda <manjunatha.gowda@...cle.com>
Signed-off-by: Yifei Liu <yifei.l.liu@...cle.com>
Reviewed-by: Jack Vogel <jack.vogel@...cle.com>
---
 drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
index a44e4bd56142..a1b9b789d1d4 100644
--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
@@ -2286,6 +2286,12 @@ static void ixgbevf_negotiate_api(struct ixgbevf_adapter *adapter)
 
 	spin_lock_bh(&adapter->mbx_lock);
 
+	/* There is no corresponding drivers in pf for
+	 * api version 1.5. Try to negociate with version
+	 * 1.5 will always fail. Start to negociate with
+	 * version 1.4.
+	 */
+	idx = 1;
 	while (api[idx] != ixgbe_mbox_api_unknown) {
 		err = hw->mac.ops.negotiate_api_version(hw, api[idx]);
 		if (!err)
-- 
2.42.0