netdev - RE: [Intel-wired-lan] [PATCH v2 iwl-next 1/3] ice: do not disable Tx queues twice in ice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 1 Mar 2024 07:34:25 +0000
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com>
To: "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Fijalkowski, Maciej"
	<maciej.fijalkowski@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Karlsson, Magnus" <magnus.karlsson@...el.com>,
	"Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH v2 iwl-next 1/3] ice: do not disable Tx
 queues twice in ice_down()

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Maciej Fijalkowski
> Sent: Friday, February 23, 2024 9:36 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Fijalkowski, Maciej <maciej.fijalkowski@...el.com>; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Karlsson, Magnus <magnus.karlsson@...el.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>
> Subject: [Intel-wired-lan] [PATCH v2 iwl-next 1/3] ice: do not disable Tx queues twice in ice_down()
>
> ice_down() clears QINT_TQCTL_CAUSE_ENA_M bit twice, which is not
> necessary. First clearing happens in ice_vsi_dis_irq() and second in
> ice_vsi_stop_tx_ring() - remove the first one.
>
> While at it, make ice_vsi_dis_irq() static as ice_down() is the only
> current caller of it.
>
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> ---
 > drivers/net/ethernet/intel/ice/ice_lib.c  | 55 -----------------------
 > drivers/net/ethernet/intel/ice/ice_lib.h  |  2 -
 > drivers/net/ethernet/intel/ice/ice_main.c | 44 ++++++++++++++++++
 > 3 files changed, 44 insertions(+), 57 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)