netdev - Re: [PATCH net-next 2/3] netdev: let netlink core handle -EMSGSIZE errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJ7eU_f+uFMfGEtHMS0XvT2z1-RDPgkeBs-VTCSNxGwPg@mail.gmail.com>
Date: Fri, 1 Mar 2024 09:37:16 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, pabeni@...hat.com, 
	johannes@...solutions.net, fw@...len.de, pablo@...filter.org, 
	idosch@...dia.com, jiri@...nulli.us, amritha.nambiar@...el.com, 
	sridhar.samudrala@...el.com, hawk@...nel.org
Subject: Re: [PATCH net-next 2/3] netdev: let netlink core handle -EMSGSIZE errors

On Fri, Mar 1, 2024 at 2:31 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Previous change added -EMSGSIZE handling to af_netlink, we don't
> have to hide these errors any longer.
>
> Theoretically the error handling changes from:
>  if (err == -EMSGSIZE)
> to
>  if (err == -EMSGSIZE && skb->len)
>
> everywhere, but in practice it doesn't matter.
> All messages fit into NLMSG_GOODSIZE, so overflow of an empty
> skb cannot happen.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>