netdev - Re: [PATCH net] page_pool: fix netlink dump stop/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJ98MPwmk845Z15LLwashiMSmvGaHtW0M5J6oAsr10ZpQ@mail.gmail.com>
Date: Fri, 1 Mar 2024 09:43:47 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, pabeni@...hat.com, 
	hawk@...nel.org
Subject: Re: [PATCH net] page_pool: fix netlink dump stop/resume

On Fri, Mar 1, 2024 at 2:13 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> If message fills up we need to stop writing. 'break' will
> only get us out of the iteration over pools of a single
> netdev, we need to also stop walking netdevs.
>
> This results in either infinite dump, or missing pools,
> depending on whether message full happens on the last
> netdev (infinite dump) or non-last (missing pools).
>
> Fixes: 950ab53b77ab ("net: page_pool: implement GET in the netlink API")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>