netdev - RE: [PATCH v6 04/11 iwl-next] idpf: refactor queue related virtchnl messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW4PR11MB5911C0E7DB23BF75E47ABE61BA5D2@MW4PR11MB5911.namprd11.prod.outlook.com>
Date: Sat, 2 Mar 2024 04:34:27 +0000
From: "Singh, Krishneil K" <krishneil.k.singh@...el.com>
To: "Brady, Alan" <alan.brady@...el.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Brady, Alan"
	<alan.brady@...el.com>, "Lobakin, Aleksander" <aleksander.lobakin@...el.com>,
	"Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>, "Bagnucki, Igor"
	<igor.bagnucki@...el.com>
Subject: RE: [PATCH v6 04/11 iwl-next] idpf: refactor queue related virtchnl
 messages

> -----Original Message-----
> From: Alan Brady <alan.brady@...el.com>
> Sent: Thursday, February 22, 2024 11:05 AM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Brady, Alan <alan.brady@...el.com>; Lobakin,
> Aleksander <aleksander.lobakin@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; Bagnucki, Igor <igor.bagnucki@...el.com>
> Subject: [PATCH v6 04/11 iwl-next] idpf: refactor queue related virtchnl
> messages
> 
> This reworks queue specific virtchnl messages to use the added
> transaction API.  It is fairly mechanical and generally makes the
> functions using it more simple. Functions using transaction API no
> longer need to take the vc_buf_lock since it's not using it anymore.
> After filling out an idpf_vc_xn_params struct, idpf_vc_xn_exec takes
> care of the send and recv handling.
> 
> This also converts those functions where appropriate to use
> auto-variables instead of manually calling kfree. This greatly
> simplifies the memory alloc paths and makes them less prone memory
> leaks.
> 
> Tested-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Reviewed-by: Igor Bagnucki <igor.bagnucki@...el.com>
> Signed-off-by: Alan Brady <alan.brady@...el.com>
> ---
>  drivers/net/ethernet/intel/idpf/idpf.h        |   2 +-
>  .../net/ethernet/intel/idpf/idpf_virtchnl.c   | 393 ++++++------------
>  2 files changed, 136 insertions(+), 259 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/idpf/idpf.h
> b/drivers/net/ethernet/intel/idpf/idpf.h
> index c3b08d4593b0..ed5474c1565a 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf.h
> +++ b/drivers/net/ethernet/intel/idpf/idpf.h

Tested-by: Krishneil Singh <krishneil.k.singh@...el.com>