netdev - RE: [PATCH v6 11/11 iwl-next] idpf: remove dealloc vector msg err in idpf_intr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MW4PR11MB59113B50E821D3917F58E0A0BA5D2@MW4PR11MB5911.namprd11.prod.outlook.com>
Date: Sat, 2 Mar 2024 04:40:13 +0000
From: "Singh, Krishneil K" <krishneil.k.singh@...el.com>
To: "Brady, Alan" <alan.brady@...el.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Brady, Alan"
	<alan.brady@...el.com>, "Lobakin, Aleksander" <aleksander.lobakin@...el.com>
Subject: RE: [PATCH v6 11/11 iwl-next] idpf: remove dealloc vector msg err in
 idpf_intr_rel

> -----Original Message-----
> From: Alan Brady <alan.brady@...el.com>
> Sent: Thursday, February 22, 2024 11:05 AM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Brady, Alan <alan.brady@...el.com>; Lobakin,
> Aleksander <aleksander.lobakin@...el.com>
> Subject: [PATCH v6 11/11 iwl-next] idpf: remove dealloc vector msg err in
> idpf_intr_rel
> 
> This error message is at best not really helpful and at worst
> misleading. If we're here in idpf_intr_rel we're likely trying to do
> remove or reset. If we're in reset, this message will fail because we
> lose the virtchnl on reset and HW is going to clean up those resources
> regardless in that case. If we're in remove and we get an error here,
> we're going to reset the device at the end of remove anyway so not a big
> deal. Just remove this message it's not useful.
> 
> Tested-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> Signed-off-by: Alan Brady <alan.brady@...el.com>
> ---
>  drivers/net/ethernet/intel/idpf/idpf_lib.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_lib.c
> b/drivers/net/ethernet/intel/idpf/idpf_lib.c
> index 0714d7dcab10..5d3532c27d57 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_lib.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_lib.c

Tested-by: Krishneil Singh <krishneil.k.singh@...el.com>