netdev - Re: [PATCH net-next v2 4/7] net: nexthop: Expose nexthop group stats to user space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce6e8ffa-c4c6-4080-a54f-7acc4371c81d@kernel.org>
Date: Fri, 1 Mar 2024 19:45:27 -0700
From: David Ahern <dsahern@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Petr Machata <petrm@...dia.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org, Ido Schimmel <idosch@...dia.com>,
 Simon Horman <horms@...nel.org>, mlxsw@...dia.com
Subject: Re: [PATCH net-next v2 4/7] net: nexthop: Expose nexthop group stats
 to user space

On 3/1/24 10:28 AM, Jakub Kicinski wrote:
> On Fri, 1 Mar 2024 08:45:52 -0700 David Ahern wrote:
>>> +	/* uint; number of packets forwarded via the nexthop group entry */  
>>
>> why not make it a u64?
> 
> I think it should be our default type. Explicit length should only 
> be picked if there's a clear reason. Too many review cycles wasted
> steering people onto correct types...
> 
> Now, I'm not sure Pablo merged the sint/uint support into libmnl,
> I can share the patches to handle them in iproute2, if that helps.
> Or just copy/paste from YNL.
> 
> I need to find the courage to ask you how we can start using YNL
> in iproute2, I really worry that we're not getting CLI tools written
> for new families any more :(

I need to find time to play around with the cli tool more; my attempts
last weekend were a bit rough hunting for the right syntax.