[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 3 Mar 2024 15:22:32 +0100
From: Eric Woudstra <ericwouds@...il.com>
To: Daniel Golle <daniel@...rotopia.org>
Cc: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>, Russell King
<linux@...linux.org.uk>, Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
Frank Wunderlich <frank-w@...lic-files.de>,
Lucien Jheng <lucien.jheng@...oha.com>, Zhi-Jun You
<hujy652@...tonmail.com>, netdev@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 net-next 2/2] net: phy: air_en8811h: Add the Airoha
EN8811H PHY driver
On 3/3/24 03:37, Daniel Golle wrote:
>> +
>> + /* BUG in PHY firmware: MDIO_AN_10GBT_STAT_LP2_5G does not get set.
>
> EN8811H completely lacks MDIO_AN_10GBT_STAT, hence referencing
> MDIO_AN_10GBT_STAT_LP2_5G here is confusing.
>
> Suggestion:
> /* BUG in PHY firmware: EN8811H_2P5G_LPA_2P5G does not get set.
>
> Or just skip that line entirely as the following two lines already
> perfectly explain the situation.
>
Thanks
I also have a reply from kernel test robot, so I'll need to fix some more.
Better to see if I can only send to the test robot first.
Powered by blists - more mailing lists