netdev - Re: [PATCH net] net/ipv6: avoid possible UAF in ip6_route_mpath

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 3 Mar 2024 16:15:52 -0700
From: David Ahern <dsahern@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com,
 syzbot <syzkaller@...glegroups.com>
Subject: Re: [PATCH net] net/ipv6: avoid possible UAF in
 ip6_route_mpath_notify()

On 3/3/24 7:48 AM, Eric Dumazet wrote:
> syzbot found another use-after-free in ip6_route_mpath_notify() [1]
> 
> Commit f7225172f25a ("net/ipv6: prevent use after free in
> ip6_route_mpath_notify") was not able to fix the root cause.
> 
> We need to defer the fib6_info_release() calls after
> ip6_route_mpath_notify(), in the cleanup phase.
> 
...
> 
> Fixes: 3b1137fe7482 ("net: ipv6: Change notifications for multipath add to RTA_MULTIPATH")
> Reported-by: syzbot <syzkaller@...glegroups.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: David Ahern <dsahern@...nel.org>
> ---
>  net/ipv6/route.c | 21 +++++++--------------
>  1 file changed, 7 insertions(+), 14 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>