netdev - Re: [PATCH net-next v5 3/7] net: stmmac: don't rely on lynx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5e2a507-d3ad-449b-9da7-6767efd6d886@lunn.ch>
Date: Mon, 4 Mar 2024 14:41:25 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Romain Gantois <romain.gantois@...tlin.com>
Cc: Russell King <linux@...linux.org.uk>,
	Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Jose Abreu <joabreu@...opsys.com>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>,
	Clément Léger <clement.leger@...tlin.com>,
	Maxime Chevallier <maxime.chevallier@...tlin.com>,
	Miquel Raynal <miquel.raynal@...tlin.com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org,
	linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH net-next v5 3/7] net: stmmac: don't rely on lynx_pcs
 presence to check for a PHY

On Fri, Mar 01, 2024 at 04:35:00PM +0100, Romain Gantois wrote:
> From: Maxime Chevallier <maxime.chevallier@...tlin.com>
> 
> When initializing attached PHYs, there are some cases where we don't expect
> any PHY to be connected. The logic uses conditions based on various local
> PCS configuration, but also calls-in phylink_expects_phy() via
> stmmac_init_phy(), which is enough to ensure we don't try to initialize a
> PHY when using a Lynx PCS, as long as we have the phy_interface set to a
> 802.3z mode and are using inband negociation.
> 
> Drop the lynx check, making the stmmac generic code more pcs_lynx-agnostic.
> 
> Signed-off-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
> [rgantois: commit log]
> Signed-off-by: Romain Gantois <romain.gantois@...tlin.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew