netdev - Re: [PATCH net-next v2] net/nlmon: Cancel setting the fields of statistics to zero.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <df93a088-e8f8-3708-8009-b0560c0d07f7@iogearbox.net>
Date: Mon, 4 Mar 2024 14:57:14 +0100
From: Daniel Borkmann <daniel@...earbox.net>
To: Jason Xing <kerneljasonxing@...il.com>, yuanli fu <fuyuanli0722@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 fuyuanli@...iglobal.com
Subject: Re: [PATCH net-next v2] net/nlmon: Cancel setting the fields of
 statistics to zero.

On 3/4/24 2:25 PM, Jason Xing wrote:
> On Mon, Mar 4, 2024 at 7:14 PM yuanli fu <fuyuanli0722@...il.com> wrote:
>> Jason Xing <kerneljasonxing@...il.com> 于2024年3月4日周一 15:05写道：
>>> On Sun, Mar 3, 2024 at 7:43 PM fuyuanli <fuyuanli@...iglobal.com> wrote:
>>>>
>>>> Since fields of rtnl_link_stats64 have been set to zero in the previous
>>>> dev_get_stats function, there is no need to set them again in the
>>>> ndo_get_stats64 function.
>>>>
>>>> Signed-off-by: fuyuanli <fuyuanli@...iglobal.com>
>>>> Link: https://lore.kernel.org/netdev/20240302105224.GA7223@didi-ThinkCentre-M920t-N000/
>>>
>>> Suggested-by: Jason Xing <kerneljasonxing@...il.com>
>>> See https://lore.kernel.org/all/CAL+tcoA=FVBJi2eJgAELhWG_f+N-kwmrHc+XRfKXhYk2RJcPKg@mail.gmail.com/
>> OK, I will submit a v3 patch which updating commit message, thanks.
> 
> I don't think you need to send a new version of the patch unless
> someone points out other changes that should be made.

I think this patch is not needed anymore, see net-next :

4f41ce81a919 ("net: nlmon: Remove init and uninit functions")
26b5df99bf60 ("net: nlmon: Simplify nlmon_get_stats64")

Thanks,
Daniel