netdev - Re: [PATCH net-next] tcp: align tcp_sock_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240304170904.GK403078@kernel.org>
Date: Mon, 4 Mar 2024 17:09:04 +0000
From: Simon Horman <horms@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, eric.dumazet@...il.com,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net-next] tcp: align tcp_sock_write_rx group

On Fri, Mar 01, 2024 at 05:19:45PM +0000, Eric Dumazet wrote:
> Stephen Rothwell and kernel test robot reported that some arches
> (parisc, hexagon) and/or compilers would not like blamed commit.
> 
> Lets make sure tcp_sock_write_rx group does not start with a hole.
> 
> While we are at it, correct tcp_sock_write_tx CACHELINE_ASSERT_GROUP_SIZE()
> since after the blamed commit, we went to 105 bytes.
> 
> Fixes: 99123622050f ("tcp: remove some holes in struct tcp_sock")
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Reported-by: kernel test robot <lkp@...el.com>
> Link: https://lore.kernel.org/netdev/20240301121108.5d39e4f9@canb.auug.org.au/
> Closes: https://lore.kernel.org/oe-kbuild-all/202403011451.csPYOS3C-lkp@intel.com/
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Simon Horman <horms@...nel.org>
Tested-by: Simon Horman <horms@...nel.org> # build-tested

...