netdev - Re: [PATCH net-next v2] tcp: Add skb addr and sock addr to arguments of tracepoint tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABbqxmc43sfNz0c=CLbYFtHy6zdMMJuKWLbCm3n1OMYE6fxjwg@mail.gmail.com>
Date: Mon, 4 Mar 2024 16:30:16 +0800
From: yuanli fu <fuyuanli0722@...il.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: rostedt@...dmis.org, mhiramat@...nel.org, mathieu.desnoyers@...icios.com, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-trace-kernel@...r.kernel.org, fuyuanli@...iglobal.com
Subject: Re: [PATCH net-next v2] tcp: Add skb addr and sock addr to arguments
 of tracepoint tcp_probe.

Eric Dumazet <edumazet@...gle.com> 于2024年3月4日周一 16:13写道：
>
> On Mon, Mar 4, 2024 at 4:46 AM fuyuanli <fuyuanli@...iglobal.com> wrote:
> >
> > It is useful to expose skb addr and sock addr to user in tracepoint
> > tcp_probe, so that we can get more information while monitoring
> > receiving of tcp data, by ebpf or other ways.
> >
> > For example, we need to identify a packet by seq and end_seq when
> > calculate transmit latency between lay 2 and lay 4 by ebpf, but which is
>
> Please use "layer 2 and layer 4".
>
> > not available in tcp_probe, so we can only use kprobe hooking
> > tcp_rcv_esatblised to get them. But we can use tcp_probe directly if skb
> > addr and sock addr are available, which is more efficient.
>
> Okay, but please fix the typo. Correct function name is tcp_rcv_established
>
> >
> > Signed-off-by: fuyuanli <fuyuanli@...iglobal.com>
> > Link: https://lore.kernel.org/netdev/20240229052813.GA23899@didi-ThinkCentre-M920t-N000/
> >
>
OK, I will submit a v3 patch, thanks for your review :)
fuyuanli