netdev - Re: [PATCH net-next v3 1/7] net: nexthop: Adjust netlink policy parsing for a new attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZebZLQs8XAfCrpul@shredder>
Date: Tue, 5 Mar 2024 10:34:53 +0200
From: Ido Schimmel <idosch@...dia.com>
To: Petr Machata <petrm@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, David Ahern <dsahern@...nel.org>,
	Simon Horman <horms@...nel.org>, mlxsw@...dia.com
Subject: Re: [PATCH net-next v3 1/7] net: nexthop: Adjust netlink policy
 parsing for a new attribute

On Mon, Mar 04, 2024 at 09:51:14PM +0100, Petr Machata wrote:
> A following patch will introduce a new attribute, op-specific flags to
> adjust the behavior of an operation. Different operations will recognize
> different flags.
> 
> - To make the differentiation possible, stop sharing the policies for get
>   and del operations.
> 
> - To allow querying for presence of the attribute, have all the attribute
>   arrays sized to NHA_MAX, regardless of what is permitted by policy, and
>   pass the corresponding value to nlmsg_parse() as well.
> 
> Signed-off-by: Petr Machata <petrm@...dia.com>
> Reviewed-by: David Ahern <dsahern@...nel.org>

Reviewed-by: Ido Schimmel <idosch@...dia.com>