[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <b28dfaba-a5d3-4c33-a07c-9d991c0235a2@app.fastmail.com>
Date: Tue, 05 Mar 2024 12:45:33 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Mina Almasry" <almasrymina@...gle.com>,
"Shailend Chand" <shailend@...gle.com>, Netdev <netdev@...r.kernel.org>,
linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
Linux-Arch <linux-arch@...r.kernel.org>, linux-kselftest@...r.kernel.org,
bpf@...r.kernel.org, linux-media@...r.kernel.org,
dri-devel@...ts.freedesktop.org
Cc: "David S . Miller" <davem@...emloft.net>,
"Eric Dumazet" <edumazet@...gle.com>, "Jakub Kicinski" <kuba@...nel.org>,
"Paolo Abeni" <pabeni@...hat.com>, "Jonathan Corbet" <corbet@....net>,
"Jeroen de Borst" <jeroendb@...gle.com>,
"Praveen Kaligineedi" <pkaligineedi@...gle.com>,
"Jesper Dangaard Brouer" <hawk@...nel.org>,
"Ilias Apalodimas" <ilias.apalodimas@...aro.org>,
"David Ahern" <dsahern@...nel.org>,
"Willem de Bruijn" <willemdebruijn.kernel@...il.com>,
shuah <shuah@...nel.org>, "Sumit Semwal" <sumit.semwal@...aro.org>,
Christian König <christian.koenig@....com>,
"Yunsheng Lin" <linyunsheng@...wei.com>,
"Harshitha Ramamurthy" <hramamurthy@...gle.com>,
"Shakeel Butt" <shakeelb@...gle.com>
Subject: Re: [net-next v1 04/16] gve: implement queue api
On Fri, Dec 8, 2023, at 01:52, Mina Almasry wrote:
> +static void *gve_rx_queue_mem_alloc(struct net_device *dev, int idx)
> +{
> + struct gve_per_rx_queue_mem_dqo *gve_q_mem;
...
> +
> + gve_q_mem = kvcalloc(1, sizeof(*gve_q_mem), GFP_KERNEL);
> + if (!gve_q_mem)
> + goto err;
[minor comment]
The structure does not seem overly large, even if you have
an array here, I don't see why you would need the vmalloc
type allocation for struct gve_per_rx_queue_mem_dqo.
Arnd
Powered by blists - more mailing lists