netdev - Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: fix typo in assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9394bbe0-66bf-433a-8aa0-4051907389b3@molgen.mpg.de>
Date: Tue, 5 Mar 2024 13:27:25 +0100
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Jesse Brandeburg <jesse.brandeburg@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org,
 Wojciech Drewek <wojciech.drewek@...el.com>, netdev@...r.kernel.org,
 Eric Dumazet <edumazet@...gle.com>, Tony Nguyen
 <anthony.l.nguyen@...el.com>,
 Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 "David S. Miller" <davem@...emloft.net>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: fix typo in assignment

Dear Jesse,

Thank you for your patch.

Am 05.03.24 um 01:37 schrieb Jesse Brandeburg:
> Fix an obviously incorrect assignment, created with a typo or cut-n-paste
> error.

It’s probably just me, but with these one letter typos I still have to 
search the diff two or three times to spot the typo. Maybe even use 
(next time) as commit message summary:

ice: Assign tx ring stats value to tx stats and not rx ones

> Fixes: 5995ef88e3a8 ("ice: realloc VSI stats arrays")
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> ---
>   drivers/net/ethernet/intel/ice/ice_lib.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c
> index 097bf8fd6bf0..fc23dbe302b4 100644
> --- a/drivers/net/ethernet/intel/ice/ice_lib.c
> +++ b/drivers/net/ethernet/intel/ice/ice_lib.c
> @@ -3192,7 +3192,7 @@ ice_vsi_realloc_stat_arrays(struct ice_vsi *vsi)
>   		}
>   	}
>   
> -	tx_ring_stats = vsi_stat->rx_ring_stats;
> +	tx_ring_stats = vsi_stat->tx_ring_stats;
>   	vsi_stat->tx_ring_stats =
>   		krealloc_array(vsi_stat->tx_ring_stats, req_txq,
>   			       sizeof(*vsi_stat->tx_ring_stats),
> 
> base-commit: 948abb59ebd3892c425165efd8fb2f5954db8de7

Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>

Kind regards,

Paul