netdev - Re: [PATCH net-next v9 07/13] ptp: Move from simple ida to xarray

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240305070349.5d1a8ff0@kernel.org>
Date: Tue, 5 Mar 2024 07:03:49 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Köry Maincent <kory.maincent@...tlin.com>
Cc: Florian Fainelli <florian.fainelli@...adcom.com>, Broadcom internal
 kernel review list <bcm-kernel-feedback-list@...adcom.com>, Andrew Lunn
 <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Richard
 Cochran <richardcochran@...il.com>, Radu Pirea
 <radu-nicolae.pirea@....nxp.com>, Jay Vosburgh <j.vosburgh@...il.com>, Andy
 Gospodarek <andy@...yhouse.net>, Nicolas Ferre
 <nicolas.ferre@...rochip.com>, Claudiu Beznea <claudiu.beznea@...on.dev>,
 Willem de Bruijn <willemdebruijn.kernel@...il.com>, Jonathan Corbet
 <corbet@....net>, Horatiu Vultur <horatiu.vultur@...rochip.com>,
 UNGLinuxDriver@...rochip.com, Simon Horman <horms@...nel.org>, Vladimir
 Oltean <vladimir.oltean@....com>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, Maxime Chevallier
 <maxime.chevallier@...tlin.com>, Rahul Rameshbabu <rrameshbabu@...dia.com>
Subject: Re: [PATCH net-next v9 07/13] ptp: Move from simple ida to xarray

On Tue, 5 Mar 2024 10:02:59 +0100 Köry Maincent wrote:
> On Mon, 4 Mar 2024 18:47:37 -0800
> Jakub Kicinski <kuba@...nel.org> wrote:
> 
> > On Mon, 26 Feb 2024 14:39:58 +0100 Kory Maincent wrote:  
> > > +static DEFINE_XARRAY_FLAGS(ptp_clocks_map, XA_FLAGS_LOCK_IRQ |
> > > XA_FLAGS_ALLOC);    
> > 
> > Why _IRQ? anything on the fastpath hopefully has a pointer to the clock
> > already, I'd hope. And we often reserve ID 0 as invalid.  
> 
> To keep the same flag as IDA_INIT_FLAGS, I am not expert in xarray so I just
> keep it without questioning it. Do you think I should remove it?

Yes, I believe those defaults are just "to be safe".

> ID 0 was valid for phc. IMHO makes it invalid is not a good idea, it
> will change the phc id value for current board on the field.

Ah, right, let's keep it then. We'll have to use -1 as invalid.

> > BTW could be a standalone patch, Xarray conversion from IDA is an
> > improvement in itself.  
> 
> Indeed. Do you prefer this patch to be standalone?

May be a personal preference but I do feel like sending general
improvements separately from large new features makes the process 
more smooth.