netdev - Re: [PATCH net-next 1/3] net: gtp: Leverage core stats allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zec8eY4IeTyD8NYK@calendula>
Date: Tue, 5 Mar 2024 16:38:33 +0100
From: Pablo Neira Ayuso <pablo@...filter.org>
To: Breno Leitao <leitao@...ian.org>
Cc: Harald Welte <laforge@...monks.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	horms@...nel.org, dsahern@...nel.org,
	"open list:GTP (GPRS Tunneling Protocol)" <osmocom-net-gprs@...ts.osmocom.org>
Subject: Re: [PATCH net-next 1/3] net: gtp: Leverage core stats allocator

On Tue, Mar 05, 2024 at 04:15:21AM -0800, Breno Leitao wrote:
> With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and
> convert veth & vrf"), stats allocation could be done on net core
> instead of in this driver.
> 
> With this new approach, the driver doesn't have to bother with error
> handling (allocation failure checking, making sure free happens in the
> right spot, etc). This is core responsibility now.
> 
> Remove the allocation in the gtp driver and leverage the network
> core allocation instead.
> 
> Signed-off-by: Breno Leitao <leitao@...ian.org>

Acked-by: Pablo Neira Ayuso <pablo@...filter.org>

Thanks, this was on my list.