netdev - Re: [PATCH bpf 1/2] xdp, bonding: Fix feature flags when there are no slave devs anymore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87cys8d6li.fsf@toke.dk>
Date: Tue, 05 Mar 2024 16:46:33 +0100
From: Toke Høiland-Jørgensen <toke@...hat.com>
To: Daniel Borkmann <daniel@...earbox.net>, bpf@...r.kernel.org
Cc: netdev@...r.kernel.org, Daniel Borkmann <daniel@...earbox.net>, Magnus
 Karlsson <magnus.karlsson@...el.com>, Prashant Batra
 <prbatra.mail@...il.com>, Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH bpf 1/2] xdp, bonding: Fix feature flags when there are
 no slave devs anymore

Daniel Borkmann <daniel@...earbox.net> writes:

> Commit 9b0ed890ac2a ("bonding: do not report NETDEV_XDP_ACT_XSK_ZEROCOPY")
> changed the driver from reporting everything as supported before a device
> was bonded into having the driver report that no XDP feature is supported
> until a real device is bonded as it seems to be more truthful given
> eventually real underlying devices decide what XDP features are supported.
>
> The change however did not take into account when all slave devices get
> removed from the bond device. In this case after 9b0ed890ac2a, the driver
> keeps reporting a feature mask of 0x77, that is, NETDEV_XDP_ACT_MASK &
> ~NETDEV_XDP_ACT_XSK_ZEROCOPY whereas it should have reported a feature
> mask of 0.
>
> Fix it by resetting XDP feature flags in the same way as if no XDP program
> is attached to the bond device. This was uncovered by the XDP bond selftest
> which let BPF CI fail. After adjusting the starting masks on the latter
> to 0 instead of NETDEV_XDP_ACT_MASK the test passes again together with
> this fix.
>
> Fixes: 9b0ed890ac2a ("bonding: do not report NETDEV_XDP_ACT_XSK_ZEROCOPY")
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> Cc: Magnus Karlsson <magnus.karlsson@...el.com>
> Cc: Prashant Batra <prbatra.mail@...il.com>
> Cc: Toke Høiland-Jørgensen <toke@...hat.com>
> Cc: Jakub Kicinski <kuba@...nel.org>

Ah yes, makes sense, of course we should reset the mask when devices are
removed!

Reviewed-by: Toke Høiland-Jørgensen <toke@...hat.com>