netdev - Re: [PATCH net v2] dpll: move all dpll<>netdev helpers to dpll code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iKkzU-0WXWs1oGD9puXXOhh2-Cx2Nt_4dc2YDRKTOSd0Q@mail.gmail.com>
Date: Tue, 5 Mar 2024 19:52:58 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, pabeni@...hat.com, 
	Geert Uytterhoeven <geert@...ux-m68k.org>, vadim.fedorenko@...ux.dev, 
	arkadiusz.kubalewski@...el.com, jiri@...nulli.us
Subject: Re: [PATCH net v2] dpll: move all dpll<>netdev helpers to dpll code

On Tue, Mar 5, 2024 at 2:35 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Older versions of GCC really want to know the full definition
> of the type involved in rcu_assign_pointer().
>
> struct dpll_pin is defined in a local header, net/core can't
> reach it. Move all the netdev <> dpll code into dpll, where
> the type is known. Otherwise we'd need multiple function calls
> to jump between the compilation units.
>
> This is the same problem the commit under fixes was trying to address,
> but with rcu_assign_pointer() not rcu_dereference().
>
> Some of the exports are not needed, networking core can't
> be a module, we only need exports for the helpers used by
> drivers.
>
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Link: https://lore.kernel.org/all/35a869c8-52e8-177-1d4d-e57578b99b6@linux-m68k.org/
> Fixes: 640f41ed33b5 ("dpll: fix build failure due to rcu_dereference_check() on unknown type")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---

Oh well :)

Reviewed-by: Eric Dumazet <edumazet@...gle.com>