netdev - Re: [PATCH net-next v2 00/22] Introducing OpenVPN Data Channel Offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240305113032.55de3d28@kernel.org>
Date: Tue, 5 Mar 2024 11:30:32 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Antonio Quartulli <antonio@...nvpn.net>
Cc: netdev@...r.kernel.org, Sergey Ryazanov <ryazanov.s.a@...il.com>, Paolo
 Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next v2 00/22] Introducing OpenVPN Data Channel
 Offload

On Mon,  4 Mar 2024 16:08:51 +0100 Antonio Quartulli wrote:
>  create mode 100644 drivers/net/ovpn/Makefile
>  create mode 100644 drivers/net/ovpn/bind.c
>  create mode 100644 drivers/net/ovpn/bind.h
>  create mode 100644 drivers/net/ovpn/crypto.c
>  create mode 100644 drivers/net/ovpn/crypto.h
>  create mode 100644 drivers/net/ovpn/crypto_aead.c
>  create mode 100644 drivers/net/ovpn/crypto_aead.h
>  create mode 100644 drivers/net/ovpn/io.c
>  create mode 100644 drivers/net/ovpn/io.h
>  create mode 100644 drivers/net/ovpn/main.c
>  create mode 100644 drivers/net/ovpn/main.h
>  create mode 100644 drivers/net/ovpn/netlink.c
>  create mode 100644 drivers/net/ovpn/netlink.h
>  create mode 100644 drivers/net/ovpn/ovpnstruct.h
>  create mode 100644 drivers/net/ovpn/packet.h
>  create mode 100644 drivers/net/ovpn/peer.c
>  create mode 100644 drivers/net/ovpn/peer.h
>  create mode 100644 drivers/net/ovpn/pktid.c
>  create mode 100644 drivers/net/ovpn/pktid.h
>  create mode 100644 drivers/net/ovpn/proto.h
>  create mode 100644 drivers/net/ovpn/skb.h
>  create mode 100644 drivers/net/ovpn/socket.c
>  create mode 100644 drivers/net/ovpn/socket.h
>  create mode 100644 drivers/net/ovpn/stats.c
>  create mode 100644 drivers/net/ovpn/stats.h
>  create mode 100644 drivers/net/ovpn/tcp.c
>  create mode 100644 drivers/net/ovpn/tcp.h
>  create mode 100644 drivers/net/ovpn/udp.c
>  create mode 100644 drivers/net/ovpn/udp.h
>  create mode 100644 include/uapi/linux/ovpn.h

At a glance you seem to be missing:
 - documentation
 - YAML spec for the netlink protocol -
   https://docs.kernel.org/next/userspace-api/netlink/specs.html
 - some basic set of tests (or mention that you'll run your own CI
   and report results to us: https://netdev.bots.linux.dev/status.html)
:)