netdev - Re: [PATCH net-next] selftests: avoid using SKIP(exit()) in harness fixure setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202403041649.51EDC22DD@keescook>
Date: Mon, 4 Mar 2024 16:49:41 -0800
From: Kees Cook <keescook@...omium.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, Mark Brown <broonie@...nel.org>,
	ivan.orlov0322@...il.com, perex@...ex.cz, tiwai@...e.com,
	shuah@...nel.org, jglisse@...hat.com, akpm@...ux-foundation.org,
	linux-sound@...r.kernel.org, linux-kselftest@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: [PATCH net-next] selftests: avoid using SKIP(exit()) in harness
 fixure setup

On Mon, Mar 04, 2024 at 03:36:20PM -0800, Jakub Kicinski wrote:
> selftest harness uses various exit codes to signal test
> results. Avoid calling exit() directly, otherwise tests
> may get broken by harness refactoring (like the commit
> under Fixes). SKIP() will instruct the harness that the
> test shouldn't run, it used to not be the case, but that
> has been fixed. So just return, no need to exit.
> 
> Note that for hmm-tests this actually changes the result
> from pass to skip. Which seems fair, the test is skipped,
> after all.
> 
> Reported-by: Mark Brown <broonie@...nel.org>
> Link: https://lore.kernel.org/all/05f7bf89-04a5-4b65-bf59-c19456aeb1f0@sirena.org.uk
> Fixes: a724707976b0 ("selftests: kselftest_harness: use KSFT_* exit codes")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook