[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CADFiAcJtJWMqeiVRLyZQivYw2J5EBeMVjP+qeJfS9YeWokdX+Q@mail.gmail.com>
Date: Tue, 5 Mar 2024 16:47:35 +0900
From: Takeru Hayasaka <hayatake396@...il.com>
To: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com>
Cc: "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Jonathan Corbet <corbet@....net>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
"vladimir.oltean@....com" <vladimir.oltean@....com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"laforge@...monks.org" <laforge@...monks.org>, Marcin Szycik <marcin.szycik@...ux.intel.com>,
"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"mailhol.vincent@...adoo.fr" <mailhol.vincent@...adoo.fr>
Subject: Re: [Intel-wired-lan] [PATCH net-next v8 1/2] ethtool: Add GTP RSS
hash options to ethtool.h
Hi Himasekhar Reddy-san
> After added the above v4 patch able to to see tab completion for flow-type but not rx-flow-hash. Please find below logs.
Sorry. I submitted a code with the conditions reversed. I have
resubmitted it, so could you please check it again?
https://lore.kernel.org/all/20240305074350.533622-1-hayatake396@gmail.com/
Takeru
2024年3月5日(火) 13:28 Pucha, HimasekharX Reddy <himasekharx.reddy.pucha@...el.com>:
>
> >-----Original Message-----
> > From: Takeru Hayasaka <hayatake396@...il.com>
> > Sent: Tuesday, March 5, 2024 9:12 AM
> > To: Pucha, HimasekharX Reddy <himasekharx.reddy.pucha@...el.com>
> > Cc: Brandeburg, Jesse <jesse.brandeburg@...el.com>; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; David S. Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Jonathan Corbet <corbet@....net>; linux-doc@...r.kernel.org; vladimir.oltean@....com; linux-kernel@...r.kernel.org; laforge@...monks.org; Marcin Szycik <marcin.szycik@...ux.intel.com>; intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; mailhol.vincent@...adoo.fr
> > Subject: Re: [Intel-wired-lan] [PATCH net-next v8 1/2] ethtool: Add GTP RSS hash options to ethtool.h
> >
> > Hi Himasekhar Reddy-san
> >
> > > Functionality wise its working fine. But the ethtool part (tab complete doesn't show GTP)
> >
> > I forgot to add the tab completion feature! Thank you for the good
> > points. I've added it again in this version's patch.
> > https://lore.kernel.org/all/20240305033555.524741-1-hayatake396@gmail.com/
> >
> > Takeru
> >
>
> After added the above v4 patch able to to see tab completion for flow-type but not rx-flow-hash. Please find below logs.
>
> # ethtool -N eth4 rx-flow-hash
> ah4 ah6 esp4 esp6 ether sctp4 sctp6 tcp4 tcp6 udp4 udp6
> # ethtool -N eth4 rx-flow-hash
> ah4 ah6 esp4 esp6 ether sctp4 sctp6 tcp4 tcp6 udp4 udp6
> # ethtool -N eth4 flow-type
> ah4 esp4 ether gtpc4t gtpc6t gtpu4d gtpu4u gtpu6d gtpu6u ip6 sctp6 tcp6 udp6
> ah6 esp6 gtpc4 gtpc6 gtpu4 gtpu4e gtpu6 gtpu6e ip4 sctp4 tcp4 udp4
>
Powered by blists - more mailing lists