netdev - Re: [PATCH net-next v6 16/16] net: dsa: vsc73xx: start treating the BR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbRrnHtknbQV_CEpWu_bsaZEdOEa-AmXWXp2Rs4bKXxTA@mail.gmail.com>
Date: Wed, 6 Mar 2024 09:36:40 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Pawel Dembicki <paweldembicki@...il.com>
Cc: netdev@...r.kernel.org, Simon Horman <horms@...nel.org>, Andrew Lunn <andrew@...n.ch>, 
	Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean <olteanv@...il.com>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Claudiu Manoil <claudiu.manoil@....com>, Alexandre Belloni <alexandre.belloni@...tlin.com>, 
	UNGLinuxDriver@...rochip.com, Russell King <linux@...linux.org.uk>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v6 16/16] net: dsa: vsc73xx: start treating the
 BR_LEARNING flag

On Fri, Mar 1, 2024 at 11:18 PM Pawel Dembicki <paweldembicki@...il.com> wrote:

> This patch implements .port_pre_bridge_flags() and .port_bridge_flags(),
> which are required for properly treating the BR_LEARNING flag. Also,
> .port_stp_state_set() is tweaked and now disables learning for standalone
> ports.
>
> Disabling learning for standalone ports is required to avoid situations
> where one port sees traffic originating from another, which could cause
> invalid operations.
>
> Signed-off-by: Pawel Dembicki <paweldembicki@...il.com>

This looks right to me:
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

I looked at all patches that I understand, the VLAN tag stuff needs to
be reviewed by Vladimir who I think has a clear idea of how that should
be done. You can add my Acked-by because I looked at them and they
look right but I can't claim to have made a thorough review on those.

Yours,
Linus Walleij