netdev - Re: [PATCH net-next 06/18] net: move ip_packet_offload and ipv6_packet_offload to net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLv8hFUDiash5LTaHg4VrzCS1QdaJR-62WNEmMVYVF7pA@mail.gmail.com>
Date: Wed, 6 Mar 2024 10:00:45 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: kernel test robot <lkp@...el.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev, 
	netdev@...r.kernel.org, David Ahern <dsahern@...nel.org>, 
	Willem de Bruijn <willemb@...gle.com>, Soheil Hassas Yeganeh <soheil@...gle.com>, 
	Neal Cardwell <ncardwell@...gle.com>, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 06/18] net: move ip_packet_offload and
 ipv6_packet_offload to net_hotdata

On Wed, Mar 6, 2024 at 7:09 AM kernel test robot <lkp@...el.com> wrote:
>
> Hi Eric,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on net-next/main]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Eric-Dumazet/net-introduce-struct-net_hotdata/20240306-001407
> base:   net-next/main
> patch link:    https://lore.kernel.org/r/20240305160413.2231423-7-edumazet%40google.com
> patch subject: [PATCH net-next 06/18] net: move ip_packet_offload and ipv6_packet_offload to net_hotdata
> config: hexagon-defconfig (https://download.01.org/0day-ci/archive/20240306/202403061318.QMW92UEi-lkp@intel.com/config)
> compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 325f51237252e6dab8e4e1ea1fa7acbb4faee1cd)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240306/202403061318.QMW92UEi-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202403061318.QMW92UEi-lkp@intel.com/

Right, all the offloads need to be there if CONFIG_INET=y, regardless
of CONFIG_IPV6

I will in v2 have changes so that the cumulative diff is :

diff --git a/include/net/hotdata.h b/include/net/hotdata.h
index 7bb6e46aec8f19deff42112041feb47724cdd538..9230052a453c1b959b9a72f1d1a4878d76f243b8
100644
--- a/include/net/hotdata.h
+++ b/include/net/hotdata.h
@@ -14,13 +14,13 @@ struct net_hotdata {
        struct net_protocol     tcp_protocol;
        struct net_offload      udpv4_offload;
        struct net_protocol     udp_protocol;
-#endif
-#if IS_ENABLED(CONFIG_IPV6)
        struct packet_offload   ipv6_packet_offload;
        struct net_offload      tcpv6_offload;
+#if defined (CONFIG_IPV6)
        struct inet6_protocol   tcpv6_protocol;
-       struct net_offload      udpv6_offload;
        struct inet6_protocol   udpv6_protocol;
+#endif
+       struct net_offload      udpv6_offload;
 #endif
        struct list_head        offload_base;
        struct list_head        ptype_all;