[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <bf1dc55e-2a8f-4d24-8a58-9ae8afe70248@lunn.ch>
Date: Wed, 6 Mar 2024 14:00:36 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Lukasz Majewski <lukma@...x.de>
Cc: Oleksij Rempel <o.rempel@...gutronix.de>,
Eric Dumazet <edumazet@...gle.com>,
Vladimir Oltean <olteanv@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
Tristram.Ha@...rochip.com,
Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
Paolo Abeni <pabeni@...hat.com>,
Ravi Gunasekaran <r-gunasekaran@...com>,
Nikita Zhandarovich <n.zhandarovich@...tech.ru>,
Murali Karicheri <m-karicheri2@...com>,
Ziyang Xuan <william.xuanziyang@...wei.com>,
Simon Horman <horms@...nel.org>
Subject: Re: [PATCH v2] net: hsr: Use full string description when opening
HSR network device
On Wed, Mar 06, 2024 at 10:40:26AM +0100, Lukasz Majewski wrote:
> Up till now only single character ('A' or 'B') was used to provide
> information of HSR slave network device status.
>
> As it is also possible and valid, that Interlink network device may
> be supported as well, the description must be more verbose. As a result
> the full string description is now used.
>
> Signed-off-by: Lukasz Majewski <lukma@...x.de>
>
> ---
> Changes for v2:
> - Use const char * instead of char * - to assure that pointed string is
> immutable (.rodata allocated).
> ---
> net/hsr/hsr_device.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/net/hsr/hsr_device.c b/net/hsr/hsr_device.c
> index 9d71b66183da..904cd8f8f830 100644
> --- a/net/hsr/hsr_device.c
> +++ b/net/hsr/hsr_device.c
> @@ -142,30 +142,29 @@ static int hsr_dev_open(struct net_device *dev)
> {
> struct hsr_priv *hsr;
> struct hsr_port *port;
> - char designation;
> + const char *designation = NULL;
Reverse Christmas Tree. This is now longer than any other variable, so
definitely should be first when sorted longest to shortest.
However, don't change the other variables. Such a cleanup should be in
a patch of its own.
Andrew
Powered by blists - more mailing lists