netdev - RE: [Intel-wired-lan] [PATCH iwl-next] ice: Add switch recipe reusing feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Wed, 6 Mar 2024 13:48:24 +0000
From: "Sharma, Mayank" <mayank.sharma@...el.com>
To: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"Zou, Steven" <steven.zou@...el.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Staikov, Andrii"
	<andrii.staikov@...el.com>, "Lobakin, Aleksander"
	<aleksander.lobakin@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "horms@...nel.org" <horms@...nel.org>,
	"Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>, "Buvaneswaran, Sujai"
	<sujai.buvaneswaran@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next] ice: Add switch recipe reusing
 feature

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Steven
> Zou
> Sent: Thursday, February 8, 2024 8:49 AM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Zou, Steven <steven.zou@...el.com>; Staikov, Andrii
> <andrii.staikov@...el.com>; Lobakin, Aleksander
> <aleksander.lobakin@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; Simon Horman <horms@...nel.org>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next] ice: Add switch recipe reusing feature
> 
> New E810 firmware supports the corresponding functionality, so the driver allows
> PFs to subscribe the same switch recipes. Then when the PF is done with a switch
> recipes, the PF can ask firmware to free that switch recipe.
> 
> When users configure a rule to PFn into E810 switch component, if there is no
> existing recipe matching this rule's pattern, the driver will request firmware to
> allocate and return a new recipe resource for the rule by calling
> ice_add_sw_recipe() and ice_alloc_recipe(). If there is an existing recipe
> matching this rule's pattern with different key value, or this is a same second rule
> to PFm into switch component, the driver checks out this recipe by calling
> ice_find_recp(), the driver will tell firmware to share using this same recipe
> resource by calling ice_subscribable_recp_shared() and ice_subscribe_recipe().
> 
> When firmware detects that all subscribing PFs have freed the switch recipe,
> firmware will free the switch recipe so that it can be reused.
> 
> This feature also fixes a problem where all switch recipes would eventually be
> exhausted because switch recipes could not be freed, as freeing a shared recipe
> could potentially break other PFs that were using it.
> 
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Reviewed-by: Andrii Staikov <andrii.staikov@...el.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Signed-off-by: Steven Zou <steven.zou@...el.com>
> ---
>  .../net/ethernet/intel/ice/ice_adminq_cmd.h   |   2 +
>  drivers/net/ethernet/intel/ice/ice_common.c   |   2 +
>  drivers/net/ethernet/intel/ice/ice_switch.c   | 187 ++++++++++++++++--
>  drivers/net/ethernet/intel/ice/ice_switch.h   |   1 +
>  drivers/net/ethernet/intel/ice/ice_type.h     |   2 +
>  5 files changed, 177 insertions(+), 17 deletions(-)
> 

We are seeing following kernel compilation error while compiling next kernel:

"error: dereferencing pointer to incomplete type 'struct dpll_pin'"

Regards,
Mayank Sharma