[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zeh8+8uK3GoN7fWX@boxer>
Date: Wed, 6 Mar 2024 15:26:03 +0100
From: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
To: Jesse Brandeburg <jesse.brandeburg@...el.com>
CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
<horms@...nel.org>, <pmenzel@...gen.mpg.de>, Alan Brady
<alan.brady@...el.com>, Tony Nguyen <anthony.l.nguyen@...el.com>, "David S.
Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH iwl-next v2 2/2] net: intel: implement modern PM ops
declarations
On Tue, Mar 05, 2024 at 06:50:22PM -0800, Jesse Brandeburg wrote:
> Switch the Intel networking drivers to use the new power management ops
> declaration formats and macros, which allows us to drop __maybe_unused,
> as well as a bunch of ifdef checking CONFIG_PM.
>
> This is safe to do because the compiler drops the unused functions,
> verified by checking for any of the power management function symbols
> being present in System.map for a build without CONFIG_PM.
>
> If a driver has runtime PM, define the ops with pm_ptr(), and if the
> driver has Simple PM, use pm_sleep_ptr(), as well as the new versions of
> the macros for declaring the members of the pm_ops structs.
>
> Checked with network-enabled allnoconfig, allyesconfig, allmodconfig on
> x64_64.
>
> Reviewed-by: Alan Brady <alan.brady@...el.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> ---
> v2: added ice driver changes to series
> v1: original net-next posting
> all changes except for ice were reviewed by Simon Horman
> no other changes besides to ice
Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> ---
> drivers/net/ethernet/intel/e100.c | 8 +++---
> drivers/net/ethernet/intel/e1000/e1000_main.c | 14 +++++-----
> drivers/net/ethernet/intel/e1000e/netdev.c | 22 +++++++---------
> drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 10 +++----
> drivers/net/ethernet/intel/i40e/i40e_main.c | 10 +++----
> drivers/net/ethernet/intel/iavf/iavf_main.c | 8 +++---
> drivers/net/ethernet/intel/ice/ice_main.c | 12 +++------
> drivers/net/ethernet/intel/igb/igb_main.c | 26 +++++++------------
> drivers/net/ethernet/intel/igbvf/netdev.c | 6 ++---
> drivers/net/ethernet/intel/igc/igc_main.c | 24 ++++++-----------
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 8 +++---
> .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 8 +++---
> 12 files changed, 64 insertions(+), 92 deletions(-)
>
Powered by blists - more mailing lists